Limit JSON number sanitization to 21 significant digits #4287

google-labs-jules · 2025-12-17T09:15:15Z

Implemented the TODO in JSONSanitizer.java to limit the number of collected digits to 21.

Modified canonicalizeNumber to stop appending digits to the sanitizedJson buffer once the count of significant digits (digitOutPos - intStart) reaches 21.
Verified the change with a reproduction script TestSanitizer.java (not committed), confirming that:
- Numbers with <= 21 digits are preserved.
- Numbers with > 21 digits are truncated to 21 digits of precision (followed by scientific notation formatting handled by existing logic).
- Example: 1234567890123456789012 (22 digits) becomes 1.23456789012345678901e+21.

PR created automatically by Jules for task 3538786990512912119 started by @shai-almog

Addresses the TODO at line 327 by capping the number of significant digits collected during number canonicalization to 21. This aligns with standard JS number string formatting (ECMA-262) and prevents excessively long number strings in sanitized JSON. Numbers with more than 21 significant digits will have their precision truncated to 21 digits before being formatted (typically into scientific notation by subsequent logic).

google-labs-jules · 2025-12-17T09:15:16Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

chatgpt-codex-connector · 2025-12-17T09:15:42Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

github-actions · 2025-12-17T09:29:22Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2280 total, 0 failed, 0 skipped
📊 Line coverage: 52.74% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.processing.TextEvaluator – 3.45%
  - com.codename1.charts.views.PieChart – 4.00%
  - com.codename1.charts.views.PieMapper – 4.88%
  - com.codename1.charts.views.ScatterChart – 5.32%
  - com.codename1.ui.list.GenericListCellRenderer$Monitor – 5.33%
  - com.codename1.ui.Display$EdtException – 5.56%
  - com.codename1.testing.AbstractTest – 6.05%
  - com.codename1.ui.Transform$ImmutableTransform – 6.06%
  - com.codename1.charts.views.DoughnutChart – 6.25%
  - com.codename1.charts.views.BubbleChart – 6.25%

Static Analysis

❌ SpotBugs: 992 findings (High: 90, Normal: 484, Low: 418) [HTML preview] [Download]
- Top findings
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:38 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:30 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:33 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
  - High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:51 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
  - …and 987 more
❌ PMD: 2727 findings (P2: 1, P3: 649, P4: 2077) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/ui/Display.java:1022 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
  - P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
  - P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8443 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/io/CSVParser.java:134 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - …and 2722 more
❌ Checkstyle: 219389 findings (Warning: 219389) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 219384 more

Generated automatically by the PR CI workflow.

shai-almog · 2025-12-17T09:29:44Z

Compared 30 screenshots: 30 matched.

Native Android coverage

📊 Line coverage: 25.00% (2666/10665 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.56% (12360/50325), branch 15.40% (714/4636), complexity 17.54% (740/4218), method 32.89% (597/1815), class 34.98% (106/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/398 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidDB – 0.00% (0/57 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 25.00% (2666/10665 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.56% (12360/50325), branch 15.40% (714/4636), complexity 17.54% (740/4218), method 32.89% (597/1815), class 34.98% (106/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/398 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidDB – 0.00% (0/57 lines covered)

shai-almog · 2025-12-17T09:48:43Z

iOS screenshot updates

Compared 30 screenshots: 27 matched, 2 updated, 1 missing reference.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

Benchmark Results

VM Translation Time: 287 seconds
Compilation Time: 50 seconds

shai-almog marked this pull request as ready for review December 17, 2025 09:15

shai-almog merged commit 94a4efb into master Dec 17, 2025
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Limit JSON number sanitization to 21 significant digits #4287

Limit JSON number sanitization to 21 significant digits #4287

Uh oh!

google-labs-jules bot commented Dec 17, 2025

Uh oh!

google-labs-jules bot commented Dec 17, 2025

Uh oh!

chatgpt-codex-connector bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

shai-almog commented Dec 17, 2025 •

edited

Loading

Uh oh!

shai-almog commented Dec 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Limit JSON number sanitization to 21 significant digits #4287

Limit JSON number sanitization to 21 significant digits #4287

Uh oh!

Conversation

google-labs-jules bot commented Dec 17, 2025

Uh oh!

google-labs-jules bot commented Dec 17, 2025

Uh oh!

chatgpt-codex-connector bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Uh oh!

shai-almog commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shai-almog commented Dec 17, 2025 •

edited

Loading

shai-almog commented Dec 17, 2025 •

edited

Loading